Revert streaming changes #4013 #4031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Alright. But then i feel like we need to revert whatever caused the performance degradations (lag spikes) at the same time, as a fix will be distant, and it's affecting too many users. From several sources, #3978 is likely to blame, so i will follow this right up with a revert on it, after which we will ask testers to take a new look. |
Dutchman101
added a commit
that referenced
this pull request
Feb 17, 2025
This reverts commit f91e1de. Details on revert: #4031 (comment) (to find out if it's the original culprit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4013 requests more tests and should be reviewed before merging.
The scope of these changes is dangerous, and the streaming logic is pretty complicated.
It's impossible to bring fixes without reviewing entire logic after changes.